Sync the pre-commit checks with what CI is doing#267
Merged
Conversation
loverdos
commented
Aug 8, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
loverdos
commented
Aug 8, 2025
aelesbao
approved these changes
Aug 8, 2025
zanicar
reviewed
Aug 8, 2025
Contributor
zanicar
left a comment
There was a problem hiding this comment.
LGTM. Although someone with more CI experience may want to confirm the details.
kouks
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and remarks
.github/workflows/sdk.ymletc.mainbranch, b) PRs. Both interoperate.actions/cachemanually, rather than relying on marketplace GitHub actions, such asactions-rust-lang/setup-rust-toolchainorSwatinem/rust-cache. Generally, GitHub actions are not composable.sccache. It looked promising, until I started getting weird errors out of the blue, likewarning: ring@0.17.14: sccache: error: failed to create directory ~/.cache/sccache/preprocessor, and so I abandonedsccachealtogether. Life is short.nexus-sdkv0.3.0) #272References
pre-commitchecks with what CI is doing. #257Checklist
write testscreate tickets forTODO: <>statementscreate or update documentation